The helpers in binder.c wrap generic list_lru and task_work inline functions and have nothing to do with binder. Move each of them to a file named after its own C header: - list_lru helpers move to list_lru.c, - init_task_work moves to task_work.c. Add the new list_lru.c to the SHRINKER entry in MAINTAINERS, which already covers include/linux/list_lru.h. Signed-off-by: Xiaobo Liu --- MAINTAINERS | 1 + rust/helpers/helpers.c | 3 ++- rust/helpers/{binder.c => list_lru.c} | 7 ------- rust/helpers/task_work.c | 13 +++++++++++++ 4 files changed, 16 insertions(+), 8 deletions(-) rename rust/helpers/{binder.c => list_lru.c} (72%) create mode 100644 rust/helpers/task_work.c diff --git a/MAINTAINERS b/MAINTAINERS index ba45953bb..428992431 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24590,6 +24590,7 @@ S: Maintained F: Documentation/admin-guide/mm/shrinker_debugfs.rst F: include/linux/list_lru.h F: include/linux/shrinker.h +F: rust/helpers/list_lru.c F: mm/list_lru.c F: mm/shrinker.c F: mm/shrinker_debug.c diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c index 998e31052..ea34101b9 100644 --- a/rust/helpers/helpers.c +++ b/rust/helpers/helpers.c @@ -43,7 +43,6 @@ #include "atomic_ext.c" #include "auxiliary.c" #include "barrier.c" -#include "binder.c" #include "bitmap.c" #include "bitops.c" #include "blk.c" @@ -69,6 +68,7 @@ #include "jump_label.c" #include "kunit.c" #include "list.c" +#include "list_lru.c" #include "maple_tree.c" #include "mm.c" #include "mutex.c" @@ -93,6 +93,7 @@ #include "string.c" #include "sync.c" #include "task.c" +#include "task_work.c" #include "time.c" #include "uaccess.c" #include "usb.c" diff --git a/rust/helpers/binder.c b/rust/helpers/list_lru.c similarity index 72% rename from rust/helpers/binder.c rename to rust/helpers/list_lru.c index a2327f1b3..3b88d1a96 100644 --- a/rust/helpers/binder.c +++ b/rust/helpers/list_lru.c @@ -5,7 +5,6 @@ */ #include -#include __rust_helper unsigned long rust_helper_list_lru_count(struct list_lru *lru) { @@ -19,9 +18,3 @@ __rust_helper unsigned long rust_helper_list_lru_walk(struct list_lru *lru, { return list_lru_walk(lru, isolate, cb_arg, nr_to_walk); } - -__rust_helper void rust_helper_init_task_work(struct callback_head *twork, - task_work_func_t func) -{ - init_task_work(twork, func); -} diff --git a/rust/helpers/task_work.c b/rust/helpers/task_work.c new file mode 100644 index 000000000..cb961cd22 --- /dev/null +++ b/rust/helpers/task_work.c @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * Copyright (C) 2025 Google LLC. + */ + +#include + +__rust_helper void rust_helper_init_task_work(struct callback_head *twork, + task_work_func_t func) +{ + init_task_work(twork, func); +} -- 2.34.1