The driver currently programs the mode only for SGMII-to-Copper, based on the PHY interface mode. Some MACs connect to the PHY via RGMII. Add code in m88e1510_config_init() to configure the device. Signed-off-by: Paul Louvel (Schneider Electric) Reviewed-by: Maxime Chevallier --- drivers/net/phy/marvell.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index a72d307eaf12..423d146426ff 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -1403,9 +1403,11 @@ static int m88e1510_config_init(struct phy_device *phydev) if (err < 0) return err; - /* SGMII-to-Copper mode initialization */ + /* RGMII/SGMII-to-Copper mode initialization */ if (phydev->interface == PHY_INTERFACE_MODE_SGMII) err = m88e1510_config_mode(phydev, MII_88E1510_GEN_CTRL_REG_1_MODE_SGMII); + else if (phy_interface_is_rgmii(phydev)) + err = m88e1510_config_mode(phydev, MII_88E1510_GEN_CTRL_REG_1_MODE_RGMII); if (err < 0) return err; -- 2.56.1