Each queue of a target_core_uring device has an array of command descriptors that the kernel fills. The server cannot read the descriptors yet. Let the server mmap() the descriptors of queue q_id at offset q_id * TCMUR_DESC_AREA_SIZE of the character device. Refuse writable mappings, as only the kernel writes descriptors. Signed-off-by: Qiliang Yuan --- drivers/target/target_core_uring.c | 22 +++++++++++++++++++++- include/uapi/linux/target_core_uring.h | 6 +++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c index d1ca4f16e7d0b..904ce2a613618 100644 --- a/drivers/target/target_core_uring.c +++ b/drivers/target/target_core_uring.c @@ -31,7 +31,7 @@ struct tcmur_dev; /** * struct tcmur_queue - One command queue - * @descs: Command descriptors, indexed by tag + * @descs: Command descriptors, indexed by tag and mapped by the server * @udev: Device the queue belongs to */ struct tcmur_queue { @@ -79,6 +79,25 @@ static size_t tcmur_desc_area_size(struct tcmur_dev *udev) return PAGE_ALIGN(udev->queue_depth * sizeof(struct tcmur_io_desc)); } +static int tcmur_ch_mmap(struct file *filp, struct vm_area_struct *vma) +{ + struct tcmur_dev *udev = filp->private_data; + u64 off = (u64)vma->vm_pgoff << PAGE_SHIFT; + u32 rem; + u64 q_id = div_u64_rem(off, TCMUR_DESC_AREA_SIZE, &rem); + + if (rem || q_id >= udev->nr_queues || + vma->vm_end - vma->vm_start != tcmur_desc_area_size(udev)) + return -EINVAL; + + /* Refuse writable mappings, as only the kernel writes descriptors */ + if (vma->vm_flags & VM_WRITE) + return -EPERM; + vm_flags_clear(vma, VM_MAYWRITE); + + return remap_vmalloc_range(vma, udev->queues[q_id].descs, 0); +} + static long tcmur_ch_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { @@ -125,6 +144,7 @@ static const struct file_operations tcmur_ch_fops = { .owner = THIS_MODULE, .open = tcmur_ch_open, .release = tcmur_ch_release, + .mmap = tcmur_ch_mmap, .unlocked_ioctl = tcmur_ch_ioctl, .compat_ioctl = compat_ptr_ioctl, }; diff --git a/include/uapi/linux/target_core_uring.h b/include/uapi/linux/target_core_uring.h index c23e01e7638a2..d2b8ffe40bf7a 100644 --- a/include/uapi/linux/target_core_uring.h +++ b/include/uapi/linux/target_core_uring.h @@ -54,7 +54,8 @@ enum tcmur_io_op { * @data_len: Bytes of data to transfer * @reserved: Zero * - * The descriptors of a queue form an array indexed by tag. + * The descriptors of a queue form an array indexed by tag, which the server + * maps read-only at offset q_id * TCMUR_DESC_AREA_SIZE of the file. */ struct tcmur_io_desc { __u32 op; @@ -65,4 +66,7 @@ struct tcmur_io_desc { __u32 reserved; }; +#define TCMUR_DESC_AREA_SIZE \ + (TCMUR_MAX_QUEUE_DEPTH * sizeof(struct tcmur_io_desc)) + #endif /* _UAPI_LINUX_TARGET_CORE_URING_H */ -- 2.43.0