rockchip_get_bank_data() obtains the bank clock with of_clk_get() and enables it before reading the GPIO version ID. The reference returned by of_clk_get() is never dropped on the error paths that follow: When the debounce clock is missing, the bank clock is disabled with clk_disable_unprepare() but the reference is never released with clk_put(). When the version ID is unsupported, the function returns -ENODEV leaving the bank clock prepared, enabled and referenced. Drop the reference with clk_put() on both error paths and disable and unprepare the bank clock on the unsupported version path so that probe failures no longer leak the clock. Fixes: 41209307cad7 ("gpio: rockchip: change the GPIO version judgment logic") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/gpio/gpio-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 44d7ebd12724..69a7cd8c9a1a 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -673,6 +673,7 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank) if (IS_ERR(bank->db_clk)) { dev_err(bank->dev, "cannot find debounce clk\n"); clk_disable_unprepare(bank->clk); + clk_put(bank->clk); return -EINVAL; } break; @@ -682,6 +683,8 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank) break; default: dev_err(bank->dev, "unsupported version ID: 0x%08x\n", id); + clk_disable_unprepare(bank->clk); + clk_put(bank->clk); return -ENODEV; } -- 2.34.1