Currently, two bearers of different media types can be added to the same device (e.g., "eth:eth0" and "ib:eth0"). This causes a leak in device->dev_refcnt as follows: tipc_enable_l2_media() dev_get_by_name() dev_hold() As a result, device->dev_refcnt is incremented twice, but the second bearer replaces the first one. Fix this by rejecting a bearer with a different media type when the device is already occupied. Fixes: cb30a63384bc ("tipc: refactor function tipc_enable_bearer()") Reported-by: Jiakai Xu Closes: http://lore.kernel.org/netdev/20260918013509.1853952-1-xujiakai24@mails.ucas.ac.cn/ Signed-off-by: Tung Nguyen --- v3: Address alternative device name issue found by sashiko v2: https://lore.kernel.org/netdev/20260924162016.1258485-1-tung.quang.nguyen@est.tech/ v1: https://lore.kernel.org/netdev/20260923091057.375981-1-tung.quang.nguyen@est.tech/ net/tipc/bearer.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 05dcd2f9e887..f480fffca843 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c @@ -285,17 +285,42 @@ static int tipc_enable_bearer(struct net *net, const char *name, bearer_id = MAX_BEARERS; i = MAX_BEARERS; while (i-- != 0) { + struct net_device *dev1, *dev2; + char *if_name; + b = rtnl_dereference(tn->bearer_list[i]); if (!b) { bearer_id = i; continue; } if (!strcmp(name, b->name)) { +duplicate: errstr = "already enabled"; NL_SET_ERR_MSG(extack, "Already enabled"); goto rejected; } + /* udp media can be used together with any media */ + if (b->media->type_id == TIPC_MEDIA_TYPE_UDP || + m->type_id == TIPC_MEDIA_TYPE_UDP) + goto priority; + + if_name = strchr((const char *)b->name, ':') + 1; + dev1 = __dev_get_by_name(net, if_name); + dev2 = __dev_get_by_name(net, b_names.if_name); + if (dev1 == dev2) { + /* Not allow eth and ib to attach to the same device */ + if (b->media != m) { + errstr = "same dev for different media"; + NL_SET_ERR_MSG(extack, + "Same dev for different media"); + goto rejected; + } else { + goto duplicate; + } + } + +priority: if (b->priority == prio && (++with_this_prio > 2)) { pr_warn("Bearer <%s>: already 2 bearers with priority %u\n", -- 2.43.0