Add errata for lan8842. The errata document can be found here [1]. This is fixing the module 7 ("1000BASE-T PMA EEE TX wake PHY-side shorted center taps") [1] https://ww1.microchip.com/downloads/aemDocuments/documents/UNG/ProductDocuments/Errata/LAN8842-Errata-DS80001172.pdf Fixes: 5a774b64cd6a ("net: phy: micrel: Add support for lan8842") Signed-off-by: Horatiu Vultur --- drivers/net/phy/micrel.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 4b526587093c6..d063e77f07f81 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -2835,6 +2835,13 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev, */ #define LAN8814_PAGE_PCS_DIGITAL 2 +/** + * LAN8814_PAGE_EEE - Selects Extended Page 3. + * + * This page contains EEE registers + */ +#define LAN8814_PAGE_EEE 3 + /** * LAN8814_PAGE_COMMON_REGS - Selects Extended Page 4. * @@ -5952,6 +5959,9 @@ static int lan8842_probe(struct phy_device *phydev) #define LAN8814_POWER_MGMT_VAL5 LAN8814_POWER_MGMT_B_C_D +#define LAN8814_EEE_WAKE_TX_TIMER 0x0e +#define LAN8814_EEE_WAKE_TX_TIMER_MAX_VAL 0x1f + static int lan8842_erratas(struct phy_device *phydev) { int ret; @@ -6023,9 +6033,16 @@ static int lan8842_erratas(struct phy_device *phydev) if (ret < 0) return ret; - return lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, - LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX, - LAN8814_POWER_MGMT_VAL4); + ret = lanphy_write_page_reg(phydev, LAN8814_PAGE_POWER_REGS, + LAN8814_POWER_MGMT_MODE_14_100BTX_EEE_TX_RX, + LAN8814_POWER_MGMT_VAL4); + if (ret < 0) + return ret; + + /* Refresh time Waketx timer */ + return lanphy_write_page_reg(phydev, LAN8814_PAGE_EEE, + LAN8814_EEE_WAKE_TX_TIMER, + LAN8814_EEE_WAKE_TX_TIMER_MAX_VAL); } static int lan8842_config_init(struct phy_device *phydev) -- 2.34.1