The cited commit added the metainfo file and configured it to be installed via Makefile.am, but forgot to update ethtool.spec.in. This causes RPM builds to fail with: error: Installed (but unpackaged) file(s) found: /usr/share/metainfo/org.kernel.software.network.ethtool.metainfo.xml Add the missing file to the %files section. Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.") Reviewed-by: Tariq Toukan Signed-off-by: Gal Pressman --- ethtool.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/ethtool.spec.in b/ethtool.spec.in index 75f9be6aafa6..f5fadf26fa64 100644 --- a/ethtool.spec.in +++ b/ethtool.spec.in @@ -35,6 +35,7 @@ make install DESTDIR=${RPM_BUILD_ROOT} %{_sbindir}/ethtool %{_mandir}/man8/ethtool.8* %{_datadir}/bash-completion/completions/ethtool +%{_datadir}/metainfo/org.kernel.software.network.ethtool.metainfo.xml %doc AUTHORS COPYING NEWS README -- 2.40.1