From: George Moussalem Move the clock property and restriction from the ethernet-phy.yaml file to the individual PHY binding files. This allows each PHY to manage its own clock requirements. Signed-off-by: George Moussalem --- Commit 350b7a258f20 introduced the clocks property with a restriction to maximum 1 to the main ethernet-phy.yaml binding for Realtek to add an optional external clock source. This is restrictive to all PHY bindings, as some PHYs may require more than 1 clock such as the IPQ5018 PHY which requires 2 clocks (for RX and TX). There are three other PHY drivers that require clock management: - Micrel: requires 1 optional clock and the micrel.yaml file already accomodates for the clock property. - SMSC: requires an optional clock and the legacy bindings file (smsc-lan87xx.txt) already accomodates for the clock property. - BCM7xxx: requires an optional clock. I could not find a bindings file for this PHY family. --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 ------ Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml index 21a1a63506f0..709ea976ef79 100644 --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml @@ -105,12 +105,6 @@ properties: 1BR-10 names. The PHY must be configured to operate in BroadR-Reach mode by software. - clocks: - maxItems: 1 - description: - External clock connected to the PHY. If not specified it is assumed - that the PHY uses a fixed crystal or an internal oscillator. - enet-phy-lane-swap: $ref: /schemas/types.yaml#/definitions/flag description: diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml index 45033c31a2d5..8a26f6941dc4 100644 --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml @@ -38,6 +38,12 @@ properties: - ethernet-phy-id001c.cad0 - ethernet-phy-id001c.cb00 + clocks: + maxItems: 1 + description: + External clock connected to the PHY. If not specified it is assumed + that the PHY uses a fixed crystal or an internal oscillator. + leds: true realtek,aldps-enable: -- 2.53.0