can_calc_bittiming() scans the possible time segment combinations and computes the prescaler for each of them as: brp = priv->clock.freq / (tsegall * bt->bitrate) bt->bitrate is supplied by userspace via IFLA_CAN_BITTIMING and tsegall * bt->bitrate is a 32 bit multiplication, so the product wraps to zero as soon as bt->bitrate carries enough factors of two for the tsegall values walked by the loop. The division then faults: Oops: divide error: 0000 [#1] SMP KASAN NOPTI RIP: 0010:can_calc_bittiming+0x32e/0xcc0 Call Trace: can_changelink+0x8ba/0x2060 __rtnl_newlink+0x1013/0x18a0 rtnl_newlink+0x6b/0xa0 rtnetlink_rcv_msg+0x6f9/0xb70 netlink_rcv_skb+0x11f/0x350 netlink_unicast+0x5f5/0x860 netlink_sendmsg+0x70a/0xba0 This does not require an absurd bitrate. With the segment limits of a typical controller tsegall reaches 256, so a bitrate of 16777216 is already enough to wrap the product, and that value is below the 20 Mbit/s CAN XL data bitrate ceiling. Any CAN driver providing a bittiming_const is affected; reproduced on dummy_can. Triggering it needs CAP_NET_ADMIN in the netns owning the device. priv->bitrate_max cannot guard against this: it is populated from the optional "max-bitrate" device tree property, so it is zero for most drivers, and can_changelink() only consults it after can_get_bittiming() has already returned. Compute the product with mul_u32_u32(), as can_fixup_bittiming() already does for bt->brp * NSEC_PER_SEC, and divide with div64_u64(). div_u64() cannot be used here because its divisor is a u32, which would truncate the product back to the faulting value. Fixes: 39549eef3587 ("can: CAN Network device driver and Netlink interface") Signed-off-by: Sureshkumar S --- drivers/net/can/dev/calc_bittiming.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/dev/calc_bittiming.c b/drivers/net/can/dev/calc_bittiming.c index 42498e9d3f38..4809f5e0c96e 100644 --- a/drivers/net/can/dev/calc_bittiming.c +++ b/drivers/net/can/dev/calc_bittiming.c @@ -119,8 +119,12 @@ int can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt, tseg >= (btc->tseg1_min + btc->tseg2_min) * 2; tseg--) { tsegall = CAN_SYNC_SEG + tseg / 2; - /* Compute all possible tseg choices (tseg=tseg1+tseg2) */ - brp = priv->clock.freq / (tsegall * bt->bitrate) + tseg % 2; + /* Compute all possible tseg choices (tseg=tseg1+tseg2). + * A 32 bit tsegall * bt->bitrate can wrap to zero for large + * userspace bitrates, so compute the product in 64 bit. + */ + brp = div64_u64(priv->clock.freq, + mul_u32_u32(tsegall, bt->bitrate)) + tseg % 2; /* choose brp step which is possible in system */ brp = (brp / btc->brp_inc) * btc->brp_inc; -- 2.43.0