ata_scsi_security_inout_xlat() tests the INC_512 bit with cdb[4] & 7. INC_512 is bit 7 of byte 4 of the SECURITY PROTOCOL IN and SECURITY PROTOCOL OUT CDBs (SPC-6, tables 280 and 282), and bits 6:0 of that byte are reserved. Test bit 7 instead. Fixes: 818831c8b22f ("libata: implement SECURITY PROTOCOL IN/OUT") Cc: stable@vger.kernel.org Signed-off-by: Niklas Cassel --- drivers/ata/libata-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 87a57495d2e4..ae062fd23684 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -4812,7 +4812,7 @@ static unsigned int ata_scsi_security_inout_xlat(struct ata_queued_cmd *qc) return 1; } - if (cdb[4] & 7) { /* INC_512 */ + if (cdb[4] & 0x80) { /* INC_512 */ if (len > 0xffff) { ata_scsi_set_invalid_field(qc->dev, scmd, 6, 0); return 1; -- 2.56.1