2) Properly include defines via +#include instead of explicit -#include "../config.h" To be honest explicit way is right way to go, but by 'properly' i mean how other plugins do i.e. 'by voting' --- output/ulogd_output_XML.c | 3 +-- src/ulogd.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/output/ulogd_output_XML.c b/output/ulogd_output_XML.c index 0e1ae7b..c661174 100644 --- a/output/ulogd_output_XML.c +++ b/output/ulogd_output_XML.c @@ -20,7 +20,7 @@ #include #include -#include "../config.h" +#include #ifdef BUILD_NFLOG #include #endif @@ -30,7 +30,6 @@ #ifdef BUILD_NFACCT #include #endif -#include #include #include #include diff --git a/src/ulogd.c b/src/ulogd.c index 917ae3a..9004286 100644 --- a/src/ulogd.c +++ b/src/ulogd.c @@ -1111,6 +1111,7 @@ static int create_stack(const char *option) /* add head of pluginstance stack to list of stacks */ llist_add(&stack->stack_list, &ulogd_pi_stacks); + ulogd_log(ULOGD_DEBUG, "pluginstance stack created: '%s'\n", option); free(buf); return 0; -- 2.51.0