When wq__attach() fails, serial_test_wq() returns early without calling wq__destroy(), leaking the skeleton resources allocated by wq__open_and_load(). Fix this by jumping to a common clean_up label that calls wq__destroy() on all exit paths after successful open_and_load. Fixes: 8290dba51910 ("selftests/bpf: wq: add bpf_wq_start() checks") Signed-off-by: Kery Qi --- tools/testing/selftests/bpf/prog_tests/wq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/wq.c b/tools/testing/selftests/bpf/prog_tests/wq.c index 1dcdeda84853..b32e22876492 100644 --- a/tools/testing/selftests/bpf/prog_tests/wq.c +++ b/tools/testing/selftests/bpf/prog_tests/wq.c @@ -17,11 +17,11 @@ void serial_test_wq(void) wq_skel = wq__open_and_load(); if (!ASSERT_OK_PTR(wq_skel, "wq_skel_load")) - return; + goto clean_up; err = wq__attach(wq_skel); if (!ASSERT_OK(err, "wq_attach")) - goto clean_up + goto clean_up; prog_fd = bpf_program__fd(wq_skel->progs.test_syscall_array_sleepable); err = bpf_prog_test_run_opts(prog_fd, &topts); -- 2.34.1