Fix a Smatch static checker warning reported by Dan: arch/x86/kvm/vmx/tdx.c:3464 __tdx_bringup() warn: missing error code 'r' Reported-by: Dan Carpenter Fixes: 61bb28279623 ("KVM: TDX: Get system-wide info about TDX module on initialization") Signed-off-by: Tony Lindgren --- arch/x86/kvm/vmx/tdx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c index 66744f5768c8..3ce7fe08afd8 100644 --- a/arch/x86/kvm/vmx/tdx.c +++ b/arch/x86/kvm/vmx/tdx.c @@ -3466,11 +3466,15 @@ static int __init __tdx_bringup(void) /* Check TDX module and KVM capabilities */ if (!tdx_get_supported_attrs(&tdx_sysinfo->td_conf) || - !tdx_get_supported_xfam(&tdx_sysinfo->td_conf)) + !tdx_get_supported_xfam(&tdx_sysinfo->td_conf)) { + r = -EINVAL; goto get_sysinfo_err; + } - if (!(tdx_sysinfo->features.tdx_features0 & MD_FIELD_ID_FEATURES0_TOPOLOGY_ENUM)) + if (!(tdx_sysinfo->features.tdx_features0 & MD_FIELD_ID_FEATURES0_TOPOLOGY_ENUM)) { + r = -EINVAL; goto get_sysinfo_err; + } /* * TDX has its own limit of maximum vCPUs it can support for all -- 2.43.0