For ternary operators in the form of "a ? true : false", if 'a' itself returns a boolean result, the ternary operator can be omitted. Remove redundant ternary operators to clean up the code. Signed-off-by: Liao Yuanhong --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c index 02c8213915a5..f876c59b661e 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c @@ -1052,8 +1052,7 @@ static void bnx2x_set_one_mac_e1x(struct bnx2x *bp, /* 57710 and 57711 do not support MOVE command, * so it's either ADD or DEL */ - bool add = (elem->cmd_data.vlan_mac.cmd == BNX2X_VLAN_MAC_ADD) ? - true : false; + bool add = elem->cmd_data.vlan_mac.cmd == BNX2X_VLAN_MAC_ADD; /* Reset the ramrod data buffer */ memset(config, 0, sizeof(*config)); -- 2.34.1