Fix a few typos, including "Moniting" in the title, and some grammar in the interval tuning example. "starts looking degrading" should be "start looking degraded for", as I think the sentence means the cold region detection starts to look worse. Rewrap where the lines got too long. Signed-off-by: Aveline Noir --- .../monitoring_intervals_tuning_example.rst | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/mm/damon/monitoring_intervals_tuning_example.rst b/Documentation/mm/damon/monitoring_intervals_tuning_example.rst index 7207cbed591f..367b031ce55a 100644 --- a/Documentation/mm/damon/monitoring_intervals_tuning_example.rst +++ b/Documentation/mm/damon/monitoring_intervals_tuning_example.rst @@ -1,8 +1,8 @@ .. SPDX-License-Identifier: GPL-2.0 -================================================= -DAMON Moniting Interval Parameters Tuning Example -================================================= +=================================================== +DAMON Monitoring Interval Parameters Tuning Example +=================================================== DAMON's monitoring parameters need tuning based on given workload and the monitoring purpose. There is a :ref:`tuning guide @@ -38,7 +38,7 @@ access-hotness of a region. It is calculated as a weighted sum of the access frequency and the age of the region. If the access frequency is 0 %, the temperature is multiplied by minus one. That is, if a region is not accessed, it gets minus temperature and it gets lower as not accessed for longer time. -The sorting is in temperature-ascendint order, so the region at the top of the +The sorting is in temperature-ascending order, so the region at the top of the list is the coldest, and the one at the bottom is the hottest one. :: # damo report access --sort_regions_by temperature @@ -56,7 +56,7 @@ list is the coldest, and the one at the bottom is the hottest one. :: total size: 62.000 GiB The list shows not seemingly hot regions, and only minimum access pattern -diversity. Every region has zero access frequency. The number of region is +diversity. Every region has zero access frequency. The number of regions is 10, which is the default ``min_nr_regions value``. Size of each region is also nearly identical. We can suspect this is because “adaptive regions adjustment” mechanism was not well working. As the guide suggested, we can get relative @@ -91,7 +91,7 @@ aggregation interval. 100ms/2s intervals: Starts Showing Small Hot Regions ==================================================== -Following the guide, increase the interval 20 times (100 milliseocnds and 2 +Following the guide, increase the interval 20 times (100 milliseconds and 2 seconds for sampling and aggregation intervals, respectively). :: # damo start -s 100ms -a 2s @@ -129,17 +129,17 @@ seconds for sampling and aggregation intervals, respectively). :: [50,400,010,000, 59,720,011,000) 4.000 KiB |* | total size: 62.000 GiB -DAMON found two distinct 4 KiB regions that pretty hot. The regions are also -well aged. The hottest 4 KiB region was keeping the access frequency for about -8 minutes, and the coldest region was keeping no access for about 7 minutes. -The distribution on the histogram also looks like having a pattern. +DAMON found two distinct 4 KiB regions that are pretty hot. The regions are +also well aged. The hottest 4 KiB region was keeping the access frequency for +about 8 minutes, and the coldest region was keeping no access for about 7 +minutes. The distribution on the histogram also looks like having a pattern. Especially, the finding of the 4 KiB regions among the 62 GiB total memory shows DAMON’s adaptive regions adjustment is working as designed. Still the number of regions is close to the ``min_nr_regions``, and sizes of cold regions are similar, though. Apparently it is improved, but it still has -rooms to improve. +room to improve. 400ms/8s intervals: Pretty Improved Results =========================================== @@ -196,8 +196,8 @@ good enough to make some meaningful memory management efficiency changes. ================================= Further double the intervals (800 milliseconds and 16 seconds for sampling -and aggregation intervals, respectively). The results is more improved for the -hot regions detection, but starts looking degrading cold regions detection. :: +and aggregation intervals, respectively). The results are more improved for the +hot regions detection, but start looking degraded for cold regions detection. :: # damo start -s 800ms -a 16s # sleep 600 @@ -243,5 +243,5 @@ Conclusion ========== With the above experimental tuning results, we can conclude the theory and the -guide makes sense to at least this workload, and could be applied to similar +guide make sense to at least this workload, and could be applied to similar cases.