VMCI already rejects datagram sends from local network namespaces, but a datagram bind still creates a receive handle in VMCI's global port space. A VMCI sender outside the namespace can therefore deliver to the local socket. Its handle also prevents a global-namespace socket from binding the same port. Reject VMCI datagram binds in local namespaces. No namespace-local datagram transport exists, so EOPNOTSUPP reflects the available receive paths. Unbound datagram connect() and sendmsg() also return EOPNOTSUPP because both call vsock_auto_bind(). The receive callback rejects any local-mode socket as a defensive check. In a KASAN/lockdep QEMU guest, a reproducer observed cross-namespace delivery and the global port collision before the fix. After the fix, local bind returns EOPNOTSUPP, the global bind succeeds, and a global VMCI datagram still reaches the global socket. Fixes: eafb64f40ca4 ("vsock: add netns to vsock core") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/sashiko-outbox-212907@kernel.org/ Acked-by: Bobby Eshleman Signed-off-by: Sergio Lopez --- Changes in v2: - Combine the VMCI receive checks and clarify the auto-bind effects on datagram connect() and sendmsg() (thanks to Stefano Garzarella). - Carry Bobby Eshleman's Acked-by. - Link to v1: https://lore.kernel.org/r/20261113-vsock-vmci-netns-isolation-v1-1-ced02054ea61@redhat.com --- net/vmw_vsock/vmci_transport.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 1f186e8f8364..d53704e31af3 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -627,7 +627,8 @@ static int vmci_transport_recv_dgram_cb(void *data, struct vmci_datagram *dg) * outside of the create and destruct socket functions. */ vsk = vsock_sk(sk); - if (!vmci_transport_allow_dgram(vsk, dg->src.context)) + if (!vsock_net_mode_global(vsk) || + !vmci_transport_allow_dgram(vsk, dg->src.context)) return VMCI_ERROR_NO_ACCESS; size = VMCI_DG_SIZE(dg); @@ -1697,6 +1698,10 @@ static int vmci_transport_dgram_bind(struct vsock_sock *vsk, u32 flags; int err; + /* VMCI handles are global and cannot serve local namespaces. */ + if (!vsock_net_mode_global(vsk)) + return -EOPNOTSUPP; + /* VMCI will select a resource ID for us if we provide * VMCI_INVALID_ID. */ --- base-commit: 65ba8f34ec886ec72b2c07ddc8cf3d815c32869d change-id: 20261113-vsock-vmci-netns-isolation-7e46732dcd73 Best regards, -- Sergio Lopez