test_memcg_inotify_delete_file() and test_memcg_inotify_delete_dir() jump to cleanup before the inotify fd is created when cg_name() or cg_create() fails, and cleanup then closes whatever fd holds: test_memcontrol.c:1685:6: warning: variable 'fd' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] Initialize fd to -1. Fixes: 2de27980e1d46 ("selftests: memcg: Add tests for IN_DELETE_SELF and IN_IGNORED") Assisted-by: LLM Signed-off-by: Sasha Levin --- tools/testing/selftests/cgroup/test_memcontrol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 0ed82347044ed..047d487f6dd57 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -1678,7 +1678,7 @@ static int test_memcg_inotify_delete_file(const char *root) { int ret = KSFT_FAIL; char *memcg = NULL; - int fd, wd; + int fd = -1, wd; memcg = cg_name(root, "memcg_test_0"); @@ -1723,7 +1723,7 @@ static int test_memcg_inotify_delete_dir(const char *root) { int ret = KSFT_FAIL; char *memcg = NULL; - int fd, wd; + int fd = -1, wd; memcg = cg_name(root, "memcg_test_0"); -- 2.53.0