run_arp_evict_nocarrier_disabled_all() reports mismatches with a "failed" line but never sets ret, so the script exits 0 even when the all.arp_evict_nocarrier=0 test fails. The 2023 bulk fix wired the other five test functions and missed this one; the v6 twin (run_ndisc_evict_nocarrier_disabled_all) already sets ret=1. Set ret=1 on mismatch. Fixes: 1856628baa170 ("selftests: net: return non-zero for failures reported in arp_ndisc_evict_nocarrier") Signed-off-by: Omokefe Emmanuel Onanaroghene --- tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh index 00758f00efbfa..4afb953a3e479 100755 --- a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh +++ b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh @@ -139,6 +139,7 @@ run_arp_evict_nocarrier_disabled_all() { echo "ok" else echo "failed" + ret=1 fi cleanup_v4 -- 2.43.0