tls_sw_sendmsg_splice() forces sg.curr = sg.end after adding the spliced page. The following non-splice sk_msg_memcopy_from_iter() is a do-while loop: it advances i with sk_msg_iter_var_next() and only then tests i != sg.end, so starting from sg.curr == sg.end it wraps the ring. Reported-by: Eddy Tsalolikhin Reported-by: Kyle Zeng Fixes: c5a595000e26 ("net: tls, update curr on splice as well") Signed-off-by: Jiayuan Chen --- net/tls/tls_sw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 365c9485bb7c..d3a9b1c41de8 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -764,8 +764,10 @@ static int tls_sw_sendmsg_splice(struct sock *sk, struct msghdr *msg, } sk_msg_page_add(msg_pl, page, part, off); - msg_pl->sg.copybreak = 0; + /* keep sg.curr on the last frag so a later copy won't wrap */ msg_pl->sg.curr = msg_pl->sg.end; + sk_msg_iter_var_prev(msg_pl->sg.curr); + msg_pl->sg.copybreak = sk_msg_elem(msg_pl, msg_pl->sg.curr)->length; sk_mem_charge(sk, part); *copied += part; try_to_copy -= part; -- 2.43.0