st_clksrc_setup_clk() obtains the LPC clock with of_clk_get() but leaks the consumer reference on two error paths: the clk_prepare_enable() failure path returns without any release, and the clk_get_rate() == 0 path only does clk_disable_unprepare() without clk_put(). Add the missing clk_put() calls, mirroring the release already done in st_clksrc_of_register() error handling. Fixes: 70bef01c0f1c ("clocksource: sti: Provide support for the ST LPC Clocksource IP") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/clocksource/clksrc_st_lpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clocksource/clksrc_st_lpc.c b/drivers/clocksource/clksrc_st_lpc.c index 419a886876e4..574b966eeb34 100644 --- a/drivers/clocksource/clksrc_st_lpc.c +++ b/drivers/clocksource/clksrc_st_lpc.c @@ -74,12 +74,14 @@ static int __init st_clksrc_setup_clk(struct device_node *np) if (clk_prepare_enable(clk)) { pr_err("clksrc-st-lpc: Failed to enable LPC clock\n"); + clk_put(clk); return -EINVAL; } if (!clk_get_rate(clk)) { pr_err("clksrc-st-lpc: Failed to get LPC clock rate\n"); clk_disable_unprepare(clk); + clk_put(clk); return -EINVAL; } -- 2.34.1