From: Arun Iyengar __stmmac_dvr_probe() enables runtime PM and takes a usage count before it registers the MDIO bus, but its error path undoes neither. After a failed or deferred probe the device never runtime-suspends. Undo both, as stmmac_dvr_remove() does. Signed-off-by: Arun Iyengar --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index f256244ce0d1..4ebf4b625374 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -8407,6 +8407,8 @@ static int __stmmac_dvr_probe(struct device *device, error_pcs_setup: stmmac_mdio_unregister(ndev); error_mdio_register: + pm_runtime_disable(device); + pm_runtime_put_noidle(device); stmmac_napi_del(ndev); error_hw_init: destroy_workqueue(priv->wq); -- 2.55.0