Kernel initialize "jiffies" timer as 5 minutes below zero, as shown in include/linux/jiffies.h /* * Have the 32 bit jiffies value wrap 5 minutes after boot * so jiffies wrap bugs show up earlier. */ #define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ)) In 32bit system, if quota->charged_from is initialized to 0 as it now, it will not adjust event if reset_interval_ms passes for the first 5 minutes. So change initialize value of quota->charged_from to INITIAL_JIFFIES. This soultion has already been applied in commit 7d70e15480c0 ("writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()") or else. Signed-off-by: Sang-Heon Jeon --- I think it would be good to add selftest of below senario. 1. Set DAMON with quota. 2. Wait and check esz is updated well. 3. If esz is not updated after quite long time, set test to fail. but I'm not sure that selftest can support environment handling; jiffies with INITIAL_JIFFIES or near there. If there is another method that i don't know. Could you please let me know? Or any better idea? --- mm/damon/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index cb41fddca78c..90317a3bcf78 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -366,7 +366,7 @@ static struct damos_quota *damos_quota_init(struct damos_quota *quota) quota->total_charged_sz = 0; quota->total_charged_ns = 0; quota->charged_sz = 0; - quota->charged_from = 0; + quota->charged_from = INITIAL_JIFFIES; quota->charge_target_from = NULL; quota->charge_addr_from = 0; quota->esz_bp = 0; -- 2.43.0