The mdiobus allocated by tn40_mdiobus_init() has no primary firmware node so its firmware node pointer points to the secondary software node added by device_add_software_node() and whose reference is released by device_remove_software_node(). As device_remove_software_node() clears the firmware node pointer, any reference taken by __mdiobus_register() needs to dropped before removing the software node. Add a comment explaining why the driver drops a reference it never took itself, and only drop the firmware node reference if it was actually taken by __mdiobus_register() as indicated by the bus state. Note that __mdiobus_register() will essentially only return early without taking the reference during development when the bus structure has not been properly initialised. And currently, not even that would lead to a use-after-free as the child PHY node holds a reference to the parent MDIO node, the child is deregistered before the parent, and software_node_unregister() returns early if the parent node has already been freed. Cc: Hans-Frieder Vogt Signed-off-by: Johan Hovold --- drivers/net/ethernet/tehuti/tn40_mdio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/tehuti/tn40_mdio.c b/drivers/net/ethernet/tehuti/tn40_mdio.c index fb1a4a2e4dbc..438f0d86c2a1 100644 --- a/drivers/net/ethernet/tehuti/tn40_mdio.c +++ b/drivers/net/ethernet/tehuti/tn40_mdio.c @@ -157,7 +157,12 @@ void tn40_swnodes_cleanup(struct tn40_priv *priv) { /* cleanup of swnodes is only needed for AQR105-based cards */ if (priv->pdev->device == PCI_DEVICE_ID_TEHUTI_TN9510) { - fwnode_handle_put(dev_fwnode(&priv->mdio->dev)); + /* + * drop any reference taken by __mdiobus_register() before + * device_remove_software_node() clears the fwnode pointer + */ + if (priv->mdio->state != MDIOBUS_ALLOCATED) + fwnode_handle_put(dev_fwnode(&priv->mdio->dev)); device_remove_software_node(&priv->mdio->dev); software_node_unregister_node_group(priv->nodes.group); } -- 2.56.1