kzalloc_obj with __GFP_NOFAIL is documented to never return failure, and checking for NULL is redundant (__GFP_NOFAIL in gfp_types.h). Besides, its caller fuse_sync_fs_writes() uses it without a NULL check (atomic_inc on new_bucket, rcu_assign_pointer). fuse_fill_super_common() passes fuse_sync_bucket_alloc() directly to rcu_assign_pointer() without NULL check either. Signed-off-by: Li Wang --- fs/fuse/inode.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 33009227e91d..e5069d2f8e90 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -676,11 +676,9 @@ static struct fuse_sync_bucket *fuse_sync_bucket_alloc(void) struct fuse_sync_bucket *bucket; bucket = kzalloc_obj(*bucket, GFP_KERNEL | __GFP_NOFAIL); - if (bucket) { - init_waitqueue_head(&bucket->waitq); - /* Initial active count */ - atomic_set(&bucket->count, 1); - } + init_waitqueue_head(&bucket->waitq); + /* Initial active count */ + atomic_set(&bucket->count, 1); return bucket; } -- 2.34.1