DAMON_RECLAIM's free memory based watermarks features were introduced as a safe guard for wrongly-tuned coldness threshold (min_age). The default watermark values were chosen to let users easily understand how those can be set and tuned. The default values are never meant to be used as are. DAMON_RECLAIM is later updated to enable PSI-driven coldness threshold auto-tuning by default. When the auto-tuning is enabled, having the watermarks with the default values makes no sense. Disable the watermarks by default. Signed-off-by: SJ Park --- mm/damon/reclaim.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index d297b1596704b..a8b18f51e99d5 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -103,12 +103,13 @@ module_param(quota_autotune_feedback, ulong, 0600); static bool autotune_monitoring_intervals __read_mostly = true; module_param(autotune_monitoring_intervals, bool, 0600); +/* Watermarks are effectively disabled by default. */ static struct damos_watermarks damon_reclaim_wmarks = { .metric = DAMOS_WMARK_FREE_MEM_RATE, .interval = 5000000, /* 5 seconds */ - .high = 500, /* 50 percent */ - .mid = 400, /* 40 percent */ - .low = 200, /* 20 percent */ + .high = 1000, /* 100 percent */ + .mid = 1000, /* 100 percent */ + .low = 0, /* 0 percent */ }; DEFINE_DAMON_MODULES_WMARKS_PARAMS(damon_reclaim_wmarks); -- 2.47.3