The receive descriptor's SWDEC bit is set when a frame still needs software decryption. It is also clear for a frame that was never encrypted. rtl92ce_rx_query_desc() nevertheless sets RX_FLAG_DECRYPTED for every frame with SWDEC clear except a protected robust management frame, including unprotected data and management frames. mac80211 then accepts an unprotected unicast data frame although a pairwise key is installed, because ieee80211_drop_unencrypted() passes frames marked as decrypted, and it accepts unprotected deauthentication and disassociation frames on a connection that uses management frame protection. A station in radio range can therefore inject plaintext data into an encrypted connection, or end a protected one, by spoofing the peer's address. Set the flag only for a protected frame that is not a robust management frame, as the rtl8188ee, rtl8192ee, rtl8723ae, rtl8723be and rtl8821ae drivers do. rtw88 dropped the same assumption in commit 0649ff58a0f6 ("rtw88: Don't set RX_FLAG_DECRYPTED if packet has no encryption"). Found by code review. Compile-tested with W=1. Fixes: 0c8173385e54 ("rtl8192ce: Add new driver") Cc: stable@vger.kernel.org Signed-off-by: Zhao Li --- No new W=1, sparse or smatch warnings. 834fc28d7880 (7.4-rc1) fixed "managment" in the comment this patch removes; with the old spelling in the removed lines it applies to 5.10.y through 7.3.y. AI assistance was used. .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c index 99472053ccff..3d11ddf86136 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c @@ -300,20 +300,13 @@ bool rtl92ce_rx_query_desc(struct ieee80211_hw *hw, rx_status->flag |= RX_FLAG_MACTIME_START; - /* hw will set stats->decrypted true, if it finds the - * frame is open data frame or mgmt frame. - * So hw will not decryption robust management frame - * for IEEE80211w but still set status->decrypted - * true, so here we should set it back to undecrypted - * for IEEE80211w frame, and mac80211 sw will help - * to decrypt it - */ + /* SWDEC is clear for plaintext too; mac80211 decrypts robust mgmt */ if (stats->decrypted) { - if ((_ieee80211_is_robust_mgmt_frame(hdr)) && - (ieee80211_has_protected(hdr->frame_control))) - rx_status->flag &= ~RX_FLAG_DECRYPTED; - else + if (ieee80211_has_protected(hdr->frame_control) && + !_ieee80211_is_robust_mgmt_frame(hdr)) rx_status->flag |= RX_FLAG_DECRYPTED; + else + rx_status->flag &= ~RX_FLAG_DECRYPTED; } /* rate_idx: index of data rate into band's * supported rates or MCS index if HT rates -- 2.56.1