From: Stefano Radaelli The binding describes micrel,rmii-reference-clock-select-25-mhz as a boolean. dt-schema requires properties ending in -mhz to contain an unsigned integer value. A bare property therefore produces a property-units.yaml type warning. Describe 25 MHz selection as <1> and keep the property restricted to KSZ8021, KSZ8031, KSZ8081 and KSZ8091 PHYs, which have the RMII reference clock select bit. The driver checks only for the property presence, so this does not change runtime behavior. Signed-off-by: Stefano Radaelli --- .../devicetree/bindings/net/micrel.yaml | 27 ++++++++++++++----- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml index 6fa568057b92..a1f876dc00de 100644 --- a/Documentation/devicetree/bindings/net/micrel.yaml +++ b/Documentation/devicetree/bindings/net/micrel.yaml @@ -63,6 +63,14 @@ properties: minimum: 0 maximum: 3 + micrel,rmii-reference-clock-select-25-mhz: + enum: [ 1 ] + description: | + RMII Reference Clock Select bit selects 25 MHz mode. + + Setting the RMII Reference Clock Select bit enables 25 MHz rather + than 50 MHz clock mode. + allOf: - $ref: ethernet-phy.yaml# - if: @@ -90,6 +98,18 @@ allOf: then: properties: micrel,led-mode: false + - if: + not: + properties: + compatible: + contains: + enum: + - ethernet-phy-id0022.1555 + - ethernet-phy-id0022.1556 + - ethernet-phy-id0022.1560 + then: + properties: + micrel,rmii-reference-clock-select-25-mhz: false - if: properties: compatible: @@ -105,13 +125,6 @@ allOf: description: The RMII reference input clock. Used to determine the XI input clock. - micrel,rmii-reference-clock-select-25-mhz: - type: boolean - description: | - RMII Reference Clock Select bit selects 25 MHz mode - - Setting the RMII Reference Clock Select bit enables 25 MHz rather - than 50 MHz clock mode. dependentRequired: micrel,rmii-reference-clock-select-25-mhz: [ clock-names ] -- 2.47.3