Use __sk_dst_get() and dst_dev_rcu(), because dst->dev could be changed under us. Fixes: 6b46ca260e22 ("net: psp: add socket security association code") Signed-off-by: Eric Dumazet Cc: Daniel Zahka Cc: Kuniyuki Iwashima Cc: Willem de Bruijn --- net/psp/psp_sock.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/net/psp/psp_sock.c b/net/psp/psp_sock.c index afa966c6b69dc657a54425656131b57645c81f6f..d19e37e939672c1f8fc0ebb62e50a3fb32cc8d25 100644 --- a/net/psp/psp_sock.c +++ b/net/psp/psp_sock.c @@ -11,21 +11,18 @@ struct psp_dev *psp_dev_get_for_sock(struct sock *sk) { + struct psp_dev *psd = NULL; struct dst_entry *dst; - struct psp_dev *psd; - - dst = sk_dst_get(sk); - if (!dst) - return NULL; rcu_read_lock(); - psd = rcu_dereference(dst->dev->psp_dev); - if (psd && !psp_dev_tryget(psd)) - psd = NULL; + dst = __sk_dst_get(sk); + if (dst) { + psd = rcu_dereference(dst_dev_rcu(dst)->psp_dev); + if (psd && !psp_dev_tryget(psd)) + psd = NULL; + } rcu_read_unlock(); - dst_release(dst); - return psd; } -- 2.51.0.384.g4c02a37b29-goog