Propagate any error encountered in iomap_read_folio() back up to its caller (otherwise a default -EIO will be passed up by filemap_read_folio() to callers). This is standard behavior for how other filesystems handle their ->read_folio() errors as well. Remove the out of date comment about setting the folio error flag. Folio error flags were removed in commit 1f56eedf7ff7 ("iomap: Remove calls to set and clear folio error flag"). Signed-off-by: Joanne Koong Reviewed-by: "Darrick J. Wong" --- fs/iomap/buffered-io.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index a83a94bc0be9..51d204f0e077 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -500,12 +500,7 @@ int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops) if (!ctx.folio_owned) folio_unlock(folio); - /* - * Just like mpage_readahead and block_read_full_folio, we always - * return 0 and just set the folio error flag on errors. This - * should be cleaned up throughout the stack eventually. - */ - return 0; + return ret; } EXPORT_SYMBOL_GPL(iomap_read_folio); -- 2.47.3