From: Clark Wang In phy_probe(), genphy_c45_read_eee_abilities() is only called when a driver uses phydrv->features. Drivers that implement .get_features are responsible for reading the EEE abilities themselves. yt8521_get_features() does not do this, so phydev->supported_eee stays empty for YT8521/YT8531S and "ethtool --show-eee" reports "EEE status: not supported", even though the PHY has the standard EEE capability registers. Call genphy_c45_read_eee_abilities() at the end of yt8521_get_features() to populate supported_eee. Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy") Signed-off-by: Clark Wang --- V2 change: - Since both the YT8521 and YT8531s, which call the yt8521_get_features(), support EEE, if genphy_c45_read_eee_abilities() returns an error, it indicates a problem with MDIO bus, and the error should be returned accordingly. --- drivers/net/phy/motorcomm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index 5071605a1a11..73b5da937d7f 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -2490,7 +2490,8 @@ static int yt8521_get_features(struct phy_device *phydev) /* add fiber's features to phydev->supported */ yt8521_prepare_fiber_features(phydev, phydev->supported); } - return ret; + + return ret ? ret : genphy_c45_read_eee_abilities(phydev); } /** -- 2.34.1