hidma_mgmt_probe() calls pm_runtime_use_autosuspend() during probe, but the probe failure path does not call the matching pm_runtime_dont_use_autosuspend() before disabling runtime PM. Add the missing pm_runtime_dont_use_autosuspend() call to the probe failure path before pm_runtime_disable() so that the autosuspend setting is properly undone during cleanup. This issue was found by manual code inspection. Fixes: 7f8f209fd6e0 ("dmaengine: add Qualcomm Technologies HIDMA management driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/dma/qcom/hidma_mgmt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c index 4805ce390ffa..d8c56af5882d 100644 --- a/drivers/dma/qcom/hidma_mgmt.c +++ b/drivers/dma/qcom/hidma_mgmt.c @@ -310,6 +310,7 @@ static int hidma_mgmt_probe(struct platform_device *pdev) return 0; out: pm_runtime_put_sync_suspend(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_disable(&pdev->dev); return rc; } -- 2.43.0