serial_test_wq() returns early when ASSERT_OK_PTR(wq_skel, "wq_skel_load") fails. In that case wq__open_and_load() may still have returned a non-NULL skeleton, and the early return skips wq__destroy(), leaking resources and triggering ASAN leak reports in selftests runs. Jump to the common clean_up label instead, so wq__destroy() is executed on all exit paths. Also fix the missing semicolon after 'goto clean_up'. Fixes: 8290dba51910 ("selftests/bpf: wq: add bpf_wq_start() checks") Signed-off-by: Kery Qi --- tools/testing/selftests/bpf/prog_tests/wq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/prog_tests/wq.c b/tools/testing/selftests/bpf/prog_tests/wq.c index 1dcdeda84853..328c393e7167 100644 --- a/tools/testing/selftests/bpf/prog_tests/wq.c +++ b/tools/testing/selftests/bpf/prog_tests/wq.c @@ -17,7 +17,7 @@ void serial_test_wq(void) wq_skel = wq__open_and_load(); if (!ASSERT_OK_PTR(wq_skel, "wq_skel_load")) - return; + goto clean_up; err = wq__attach(wq_skel); if (!ASSERT_OK(err, "wq_attach")) -- 2.34.1