Since commit 5d6b58c932ec ("net: lockless sock_i_ino()"), sk_set_socket() reads i_uid and i_ino through SOCK_INODE(sock). sock_init_data_uid() calls sk_set_socket(), but its only direct users are tun and tap, which pass &tfile->socket and &q->sock. Those sockets are embedded in struct tun_file and struct tap_queue, not in a struct socket_alloc, so SOCK_INODE() points at whatever follows the socket in those structures and both reads return unrelated data. sk_uid is overwritten a few lines later with the uid passed in, and nothing reads sk_ino of a tun or tap socket today, so the result is not used. The reads themselves are still out of type, and with CONFIG_RANDSTRUCT the inode fields can land beyond the end of struct tap_queue. sock_init_data_uid() was added so that tun and tap would not use SOCK_INODE() on these sockets. Set sk_socket directly there, clear sk_ino, and let sock_init_data(), whose sockets always come from sockfs, fill in sk_ino. Found by LLM-assisted source review and confirmed by code inspection only; the out-of-type reads were not triggered at runtime. The fix was build tested only; it was not run against selftests. Fixes: 5d6b58c932ec ("net: lockless sock_i_ino()") Signed-off-by: Ziheng Wei --- Notes: Changes in v2: - Use plain assignments for sk_socket and sk_ino during socket initialization, before the socket is published (suggested by Kuniyuki Iwashima) - v1: https://lore.kernel.org/all/20261115161820.941166-1-zihengw03@163.com/ The changelog was drafted with an AI assistant from my analysis; I have reviewed the code, the fix and the text. net/core/sock.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/core/sock.c b/net/core/sock.c index ad414878d..ce7e1cf0d 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -3831,7 +3831,11 @@ void sock_init_data_uid(struct socket *sock, struct sock *sk, kuid_t uid) sk->sk_sndbuf = READ_ONCE(sysctl_wmem_default); sk->sk_state = TCP_CLOSE; sk->sk_use_task_frag = true; - sk_set_socket(sk, sock); + /* tun and tap pass a socket that is not part of a socket_alloc, so + * SOCK_INODE() must not be used here. sock_init_data() sets sk_ino. + */ + sk->sk_socket = sock; + sk->sk_ino = 0; sock_set_flag(sk, SOCK_ZAPPED); @@ -3897,6 +3901,8 @@ void sock_init_data(struct socket *sock, struct sock *sk) make_kuid(sock_net(sk)->user_ns, 0); sock_init_data_uid(sock, sk, uid); + if (sock) + sk->sk_ino = SOCK_INODE(sock)->i_ino; } EXPORT_SYMBOL(sock_init_data); base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa -- 2.43.0