`qfq_class->leaf_qdisc->q.qlen > 0` does not imply that the class
itself is active.
Two qfq_class objects may point to the same leaf_qdisc. This happens
when:
1. one QFQ qdisc is attached to the dev as the root qdisc, and
2. another QFQ qdisc is temporarily referenced (e.g., via qdisc_get()
/ qdisc_put()) and is pending to be destroyed, as in function
tc_new_tfilter.
When packets are enqueued through the root QFQ qdisc, the shared
leaf_qdisc->q.qlen increases. At the same time, the second QFQ
qdisc triggers qdisc_put and qdisc_destroy: the qdisc enters
qfq_reset() with its own q->q.qlen == 0, but its class's leaf
qdisc->q.qlen > 0. Therefore, the qfq_reset would wrongly deactivate
an inactive aggregate and trigger a null-deref in qfq_deactivate_agg:
[ 0.977749] Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KAI
[ 0.978440] KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
[ 0.978875] CPU: 0 UID: 0 PID: 135 Comm: exploit Not tainted 6.12.57 #3
[ 0.979270] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.17.0-0-gb52ca86e094d-prebuilt.qemu.or4
[ 0.979913] RIP: qfq_deactivate_agg+0x187/0xca0
[ 0.980200] Code: 00 fc ff df 48 89 fe 48 c1 ee 03 80 3c 16 00 0f 85 1d 09 00 00 48 be 00 00 00 00 00 fc ff df 48 80
Code starting with the faulting instruction
===========================================
0: 00 fc add %bh,%ah
2: ff lcall (bad)
3: df 48 89 fisttps -0x77(%rax)
6: fe 48 c1 decb -0x3f(%rax)
9: ee out %al,(%dx)
a: 03 80 3c 16 00 0f add 0xf00163c(%rax),%eax
10: 85 1d 09 00 00 48 test %ebx,0x48000009(%rip) # 0x4800001f
16: be 00 00 00 00 mov $0x0,%esi
1b: 00 fc add %bh,%ah
1d: ff lcall (bad)
1e: df 48 80 fisttps -0x80(%rax)
[ 0.981234] RSP: 0018:ffff8880106d73f8 EFLAGS: 00010246
[ 0.981517] RAX: 0000000000000000 RBX: ffff88800c518000 RCX: ffff888010bc1358
[ 0.981943] RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000
[ 0.982336] RBP: ffff888010bc1340 R08: ffff88800c518158 R09: ffff88800c518158
[ 0.982734] R10: 1ffff110018a302c R11: ffffffff89689156 R12: 0000000000000000
[ 0.983140] R13: ffff888010bc0180 R14: 0000000000000000 R15: ffff888010bc1350
[ 0.983521] FS: 0000000009737380(0000) GS:ffff8880bf000000(0000) knlGS:0000000000000000
[ 0.983955] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.984270] CR2: 00000000097c1000 CR3: 000000000ee7c004 CR4: 0000000000772ef0
[ 0.984654] PKRU: 55555554
[ 0.984804] Call Trace:
[ 0.984957]
[ 0.985084] qfq_reset_qdisc+0x27c/0x3e0
[ 0.985316] ? __pfx_mutex_lock+0x10/0x10
[ 0.985541] qdisc_reset+0x9d/0x590
[ 0.985736] ? __tcf_block_put+0x2e/0x2b0
[ 0.985980] ? __pfx_mutex_unlock+0x10/0x10
[ 0.986237] ? __tcf_chain_put+0x4a/0x880
[ 0.986465] __qdisc_destroy+0xb2/0x280
[ 0.986686] tc_new_tfilter+0x9af/0x2180
[ 0.986932] ? __pfx_stack_trace_consume_entry+0x10/0x10
[ 0.987216] ? __pfx_stack_trace_consume_entry+0x10/0x10
[ 0.987505] ? __pfx_tc_new_tfilter+0x10/0x10
[ 0.987755] ? unwind_get_return_address+0x5e/0xa0
[ 0.988025] ? arch_stack_walk+0xac/0x100
[ 0.988241] ? stack_depot_save_flags+0x29/0x7e0
[ 0.988506] ? stack_trace_save+0x94/0xd0
[ 0.988722] ? security_capable+0xda/0x160
[ 0.988970] rtnetlink_rcv_msg+0x543/0xc50
[ 0.989204] ? __pfx_rtnetlink_rcv_msg+0x10/0x10
[ 0.989458] netlink_rcv_skb+0x134/0x370
[ 0.989676] ? __pfx_rtnetlink_rcv_msg+0x10/0x10
[ 0.989951] ? __pfx_netlink_rcv_skb+0x10/0x10
[ 0.990190] ? __pfx___netlink_lookup+0x10/0x10
[ 0.990440] ? kasan_save_track+0x14/0x30
[ 0.990659] ? _copy_from_iter+0x214/0x1100
[ 0.990886] netlink_unicast+0x6db/0xa20
[ 0.991116] ? __pfx_netlink_unicast+0x10/0x10
[ 0.991355] ? unwind_get_return_address+0x5e/0xa0
[ 0.991616] ? arch_stack_walk+0xac/0x100
[ 0.991854] ? __check_object_size+0x46c/0x690
[ 0.992091] netlink_sendmsg+0x72b/0xbd0
[ 0.992301] ? __pfx_netlink_sendmsg+0x10/0x10
[ 0.992545] ? __pfx_aa_file_perm+0x10/0x10
[ 0.992793] sock_write_iter+0x489/0x560
[ 0.993043] ? kmem_cache_free+0x249/0x4b0
[ 0.993282] ? __pfx_sock_write_iter+0x10/0x10
[ 0.993565] ? security_file_permission+0x7e/0xe0
[ 0.993922] ? rw_verify_area+0x70/0x4d0
[ 0.994192] vfs_write+0x930/0xea0
[ 0.994439] ? __pfx_vfs_write+0x10/0x10
[ 0.994642] ? fdget_pos+0x57/0x4f0
[ 0.994810] ? __call_rcu_common.constprop.0+0x247/0x7a0
[ 0.995105] ksys_write+0x17c/0x1d0
[ 0.995290] ? __pfx_ksys_write+0x10/0x10
[ 0.995511] ? __x64_sys_close+0x7c/0xd0
[ 0.995732] do_syscall_64+0x58/0x120
[ 0.995959] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ 0.996233] RIP: 0033:0x424c34
[ 0.996397] Code: 89 02 48 c7 c0 ff ff ff ff eb bd 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 80 3d 2d 44 09 00 09
Code starting with the faulting instruction
===========================================
0: 89 02 mov %eax,(%rdx)
2: 48 c7 c0 ff ff ff ff mov $0xffffffffffffffff,%rax
9: eb bd jmp 0xffffffffffffffc8
b: 66 2e 0f 1f 84 00 00 cs nopw 0x0(%rax,%rax,1)
12: 00 00 00
15: 90 nop
16: f3 0f 1e fa endbr64
1a: 80 3d 2d 44 09 00 09 cmpb $0x9,0x9442d(%rip) # 0x9444e
[ 0.997360] RSP: 002b:00007ffea27af418 EFLAGS: 00000202 ORIG_RAX: 0000000000000001
[ 0.997746] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 0000000000424c34
[ 0.998123] RDX: 000000000000003c RSI: 00000000097bf5d0 RDI: 0000000000000003
[ 0.998495] RBP: 00007ffea27af460 R08: 0000000000000000 R09: 0000000000000000
[ 0.998862] R10: 0000000000000001 R11: 0000000000000202 R12: 00007ffea27af5c8
[ 0.999224] R13: 00007ffea27af5d8 R14: 00000000004b3828 R15: 0000000000000001
[ 0.999592]
[ 0.999711] Modules linked in:
[ 0.999899] ---[ end trace 0000000000000000 ]---
[ 1.000143] RIP: qfq_deactivate_agg+0x187/0xca0
[ 1.000396] Code: 00 fc ff df 48 89 fe 48 c1 ee 03 80 3c 16 00 0f 85 1d 09 00 00 48 be 00 00 00 00 00 fc ff df 48 80
Code starting with the faulting instruction
===========================================
0: 00 fc add %bh,%ah
2: ff lcall (bad)
3: df 48 89 fisttps -0x77(%rax)
6: fe 48 c1 decb -0x3f(%rax)
9: ee out %al,(%dx)
a: 03 80 3c 16 00 0f add 0xf00163c(%rax),%eax
10: 85 1d 09 00 00 48 test %ebx,0x48000009(%rip) # 0x4800001f
16: be 00 00 00 00 mov $0x0,%esi
1b: 00 fc add %bh,%ah
1d: ff lcall (bad)
1e: df 48 80 fisttps -0x80(%rax)
[ 1.001456] RSP: 0018:ffff8880106d73f8 EFLAGS: 00010246
[ 1.001735] RAX: 0000000000000000 RBX: ffff88800c518000 RCX: ffff888010bc1358
[ 1.002107] RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000
[ 1.002478] RBP: ffff888010bc1340 R08: ffff88800c518158 R09: ffff88800c518158
[ 1.002853] R10: 1ffff110018a302c R11: ffffffff89689156 R12: 0000000000000000
[ 1.003204] R13: ffff888010bc0180 R14: 0000000000000000 R15: ffff888010bc1350
[ 1.003559] FS: 0000000009737380(0000) GS:ffff8880bf000000(0000) knlGS:0000000000000000
[ 1.003962] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1.004243] CR2: 00000000097c1000 CR3: 000000000ee7c004 CR4: 0000000000772ef0
[ 1.004599] PKRU: 55555554
[ 1.004740] Kernel panic - not syncing: Fatal exception
[ 1.005071] Kernel Offset: disabled
Fixes: 0545a3037773 ("pkt_sched: QFQ - quick fair queue scheduler")
Signed-off-by: Xiang Mei
---
v2: attach the crash information to the commit message
net/sched/sch_qfq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index d920f57dc6d7..f4013b547438 100644
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -1481,7 +1481,7 @@ static void qfq_reset_qdisc(struct Qdisc *sch)
for (i = 0; i < q->clhash.hashsize; i++) {
hlist_for_each_entry(cl, &q->clhash.hash[i], common.hnode) {
- if (cl->qdisc->q.qlen > 0)
+ if (cl_is_active(cl))
qfq_deactivate_class(q, cl);
qdisc_reset(cl->qdisc);
--
2.43.0