Kernels built with CONFIG_INIT_STACK_ALL_ZERO, the default when the compiler supports it, clear every local variable on function entry. For the 256-byte struct perf_sample_data in do_perf_sw_event() that is a memset, and it runs on every entry, before the list of events is even looked up. do_perf_sw_event() is entered for a software event, e.g. a context switch, as soon as one event of that kind is open anywhere in the system. Counting events add to event->count and never read the struct. For every matching event, perf_sample_data_init() resets sample_flags, period and dyn_size and stores the address if there is one; for a sampling event, perf_prepare_sample() then fills in what its sample_type asks for. A single context-switch counter, e.g. one kept open by a monitoring daemon, is enough for every context switch on the machine to pay for the clearing. On hosts running many small VMs, ___perf_sw_event() is 0.3% of all kernel cycles, and the memset about a seventh of that. Mark the struct __uninitialized, which is what kernels without stack auto-initialization get anyway. Because its contents are copied into a ring buffer that userspace maps, every field that is read must have been written first. That holds for perf_output_sample(), and with the previous patch also for what a BPF program can read through bpf_perf_event_data. In a KVM guest on AMD Zen 5 with software counters open on every CPU, this cuts the time they add to a context switch from 54 ns to 44 ns (sched_yield() between two threads on one CPU, with spec_rstack_overflow=off). Signed-off-by: Usama Arif --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 57ea7e3c01a025..fa10ad7cfd99af 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -11212,7 +11212,7 @@ static void do_perf_sw_event(enum perf_type_id type, u32 event_id, u64 nr, struct pt_regs *regs, u64 addr) { struct swevent_htable *swhash = this_cpu_ptr(&swevent_htable); - struct perf_sample_data data; + struct perf_sample_data data __uninitialized; struct perf_event *event; struct hlist_head *head; -- 2.53.1-Meta