Three tests are added. Test 1: VERBOSE=1 ./clang_parm_optimized.sh BTF: BTF: int foo(int a, int c); DWARF: DWARF: int foo(int a, int b, int c); where parameber 'b' is unused. Test 2: VERBOSE=1 ./clang_parm_optimized_stack.sh BTF: BTF: int foo(int a, int i); DWARF: DWARF: int foo(int a, int b, int c, int d, int e, int f, int g, int h, int i); where parameters 'b' to 'h' are unused. Test 3: VERBOSE=1 ./clang_parm_aggregate.sh BTF (x86_64): long foo(long a__f1, struct t b, int i); BTF (aarch64): long foo(struct t a, struct t b, int i); DWARF: long foo(struct t a, struct t b, int i); where the 'struct t' definition is 'struct t { long f1; long f2; };', and a.f2 is not used in the function for x86_64 arch. Signed-off-by: Yonghong Song --- tests/clang_parm_aggregate.sh | 85 +++++++++++++++++++++++++++++ tests/clang_parm_optimized.sh | 63 +++++++++++++++++++++ tests/clang_parm_optimized_stack.sh | 63 +++++++++++++++++++++ 3 files changed, 211 insertions(+) create mode 100755 tests/clang_parm_aggregate.sh create mode 100755 tests/clang_parm_optimized.sh create mode 100755 tests/clang_parm_optimized_stack.sh diff --git a/tests/clang_parm_aggregate.sh b/tests/clang_parm_aggregate.sh new file mode 100755 index 0000000..9502f8b --- /dev/null +++ b/tests/clang_parm_aggregate.sh @@ -0,0 +1,85 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0-only + +source test_lib.sh + +outdir=$(make_tmpdir) + +# Comment this out to save test data. +trap cleanup EXIT + +title_log "Validation of BTF encoding of true_signatures." + +clang_true="${outdir}/clang_true" +CC=$(which clang 2>/dev/null) + +if [[ -z "$CC" ]]; then + info_log "skip: clang not available" + test_skip +fi + +cat > ${clang_true}.c << EOF +struct t { long f1; long f2; }; +__attribute__((noinline)) static long foo(struct t a, struct t b, int i) +{ + return a.f1 + b.f1 + b.f2 + i; +} + +struct t p1, p2; +int i; +int main() +{ + return (int)foo(p1, p2, i); +} +EOF + +CFLAGS="$CFLAGS -g -O2" +${CC} ${CFLAGS} -o $clang_true ${clang_true}.c +if [[ $? -ne 0 ]]; then + error_log "Could not compile ${clang_true}.c" + test_fail +fi +LLVM_OBJCOPY=objcopy pahole -J --btf_features=+true_signature $clang_true +if [[ $? -ne 0 ]]; then + error_log "Could not encode BTF for $clang_true" + test_fail +fi + +btf_optimized=$(pfunct --all --format_path=btf $clang_true |grep "foo") +if [[ -z "$btf_optimized" ]]; then + info_log "skip: no optimizations applied." + test_skip +fi + +btf_cmp=$btf_optimized +dwarf=$(pfunct --all $clang_true |grep "foo") + +verbose_log "BTF: $btf_optimized DWARF: $dwarf" + +arch=$(uname -m) + +if [[ "$arch" == "x86_64" ]]; then + # On x86_64, clang emits DW_CC_nocall for optimized functions, + # so pahole should detect the optimization and produce a + # different BTF signature. + if [[ "$btf_cmp" == "$dwarf" ]]; then + error_log "BTF and DWARF signatures should be different and they are not: BTF: $btf_optimized ; DWARF $dwarf" + test_fail + fi +elif [[ "$arch" == "aarch64" ]]; then + # On arm64, clang does not emit DW_CC_nocall, so pahole cannot + # detect the optimization. BTF and DWARF signatures are expected + # to be the same. + if [[ "$btf_cmp" != "$dwarf" ]]; then + error_log "On arm64, BTF and DWARF signatures should be the same but they are not: BTF: $btf_optimized ; DWARF $dwarf" + test_fail + fi +else + # On other architectures, skip if we cannot determine the + # expected behavior. + if [[ "$btf_cmp" == "$dwarf" ]]; then + info_log "skip: no optimization detected on $arch" + test_skip + fi +fi +test_pass diff --git a/tests/clang_parm_optimized.sh b/tests/clang_parm_optimized.sh new file mode 100755 index 0000000..81d50af --- /dev/null +++ b/tests/clang_parm_optimized.sh @@ -0,0 +1,63 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0-only + +source test_lib.sh + +outdir=$(make_tmpdir) + +# Comment this out to save test data. +trap cleanup EXIT + +title_log "Validation of BTF encoding of true_signatures." + +clang_true="${outdir}/clang_true" +CC=$(which clang 2>/dev/null) + +if [[ -z "$CC" ]]; then + info_log "skip: clang not available" + test_skip +fi + +cat > ${clang_true}.c << EOF +__attribute__((noinline)) static int foo(int a, int b, int c) +{ + return a * c - a - c; +} + +int a, b, c; +int main() +{ + return foo(a, b, c); +} +EOF + +CFLAGS="$CFLAGS -g -O2" +${CC} ${CFLAGS} -o $clang_true ${clang_true}.c +if [[ $? -ne 0 ]]; then + error_log "Could not compile ${clang_true}.c" + test_fail +fi +LLVM_OBJCOPY=objcopy pahole -J --btf_features=+true_signature $clang_true +if [[ $? -ne 0 ]]; then + error_log "Could not encode BTF for $clang_true" + test_fail +fi + +btf_optimized=$(pfunct --all --format_path=btf $clang_true |grep "foo") +if [[ -z "$btf_optimized" ]]; then + info_log "skip: no optimizations applied." + test_skip +fi + +btf_cmp=$btf_optimized +dwarf=$(pfunct --all $clang_true |grep "foo") + +if [[ -n "$VERBOSE" ]]; then + printf " BTF: %s DWARF: %s\n" "$btf_optimized" "$dwarf" +fi + +if [[ "$btf_cmp" == "$dwarf" ]]; then + error_log "BTF and DWARF signatures should be different and they are not: BTF: $btf_optimized ; DWARF $dwarf" + test_fail +fi +test_pass diff --git a/tests/clang_parm_optimized_stack.sh b/tests/clang_parm_optimized_stack.sh new file mode 100755 index 0000000..afdc355 --- /dev/null +++ b/tests/clang_parm_optimized_stack.sh @@ -0,0 +1,63 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0-only + +source test_lib.sh + +outdir=$(make_tmpdir) + +# Comment this out to save test data. +trap cleanup EXIT + +title_log "Validation of BTF encoding of true_signatures." + +clang_true="${outdir}/clang_true" +CC=$(which clang 2>/dev/null) + +if [[ -z "$CC" ]]; then + info_log "skip: clang not available" + test_skip +fi + +cat > ${clang_true}.c << EOF +__attribute__((noinline)) static int foo(int a, int b, int c, int d, int e, int f, int g, int h, int i) +{ + return a * i - a - i; +} + +int a, b, c, d, e, f, g, h, i; +int main() +{ + return foo(a, b, c, d, e, f, g, h, i); +} +EOF + +CFLAGS="$CFLAGS -g -O2" +${CC} ${CFLAGS} -o $clang_true ${clang_true}.c +if [[ $? -ne 0 ]]; then + error_log "Could not compile ${clang_true}.c" + test_fail +fi +LLVM_OBJCOPY=objcopy pahole -J --btf_features=+true_signature $clang_true +if [[ $? -ne 0 ]]; then + error_log "Could not encode BTF for $clang_true" + test_fail +fi + +btf_optimized=$(pfunct --all --format_path=btf $clang_true |grep "foo") +if [[ -z "$btf_optimized" ]]; then + info_log "skip: no optimizations applied." + test_skip +fi + +btf_cmp=$btf_optimized +dwarf=$(pfunct --all $clang_true |grep "foo") + +if [[ -n "$VERBOSE" ]]; then + printf " BTF: %s DWARF: %s\n" "$btf_optimized" "$dwarf" +fi + +if [[ "$btf_cmp" == "$dwarf" ]]; then + error_log "BTF and DWARF signatures should be different and they are not: BTF: $btf_optimized ; DWARF $dwarf" + test_fail +fi +test_pass -- 2.53.0-Meta