All callers initialize the link status as up. This change is in line with how of_phy_register_fixed_link() behaves. Signed-off-by: Heiner Kallweit --- drivers/net/phy/fixed_phy.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 32a9b99af..f50607fb6 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -144,13 +144,11 @@ struct phy_device *fixed_phy_register(const struct fixed_phy_status *status, } /* propagate the fixed link values to struct phy_device */ - phy->link = status->link; - if (status->link) { - phy->speed = status->speed; - phy->duplex = status->duplex; - phy->pause = status->pause; - phy->asym_pause = status->asym_pause; - } + phy->link = 1; + phy->speed = status->speed; + phy->duplex = status->duplex; + phy->pause = status->pause; + phy->asym_pause = status->asym_pause; of_node_get(np); phy->mdio.dev.of_node = np; @@ -174,7 +172,6 @@ EXPORT_SYMBOL_GPL(fixed_phy_register); struct phy_device *fixed_phy_register_100fd(void) { static const struct fixed_phy_status status = { - .link = true, .speed = SPEED_100, .duplex = DUPLEX_FULL, }; -- 2.51.2