netlink_realloc_groups() sizes nlk->groups to the number of groups that exist at bind/ADD_MEMBERSHIP time. When more multicast groups are registered later (e.g. a new genl family), existing sockets keep their smaller bitmap. __netlink_clear_multicast_users() however iterates every group of the departing family and calls netlink_update_socket_mc() for each socket on mc_list, which does test_bit()/__assign_bit() on group - 1 with no regard to nlk->ngroups. A stale socket therefore gets bits read and cleared past its bitmap allocation, corrupting whichever heap object follows it; the corruption repeats on every family unregister. Skip groups that lie beyond the socket's bitmap: such a socket could never have joined them. This issue was discovered by Tencent CodeBuddy Security. Cc: stable@vger.kernel.org Fixes: b4ff4f0419ae ("[NETLINK]: allocate group bitmaps dynamically") Signed-off-by: Henry Martin --- net/netlink/af_netlink.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 9fdf964224ab4..8cc655aa927f1 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1657,6 +1657,12 @@ static void netlink_update_socket_mc(struct netlink_sock *nlk, { int old, new = !!is_new, subscriptions; + /* A socket whose bitmap predates this group can never be a member; + * don't touch bits beyond its allocation. + */ + if (group - 1 >= nlk->ngroups) + return; + old = test_bit(group - 1, nlk->groups); subscriptions = nlk->subscriptions - old + new; __assign_bit(group - 1, nlk->groups, new); -- 2.43.7