For ternary operators in the form of "a ? true : false", if 'a' itself returns a boolean result, the ternary operator can be omitted. Remove redundant ternary operators to clean up the code. Signed-off-by: Liao Yuanhong --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c index 7e88d7234b14..f5e0f784ec56 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c @@ -463,8 +463,7 @@ bool hw_atl_utils_ver_match(u32 ver_expected, u32 ver_actual) ver_match = (dw_major_mask & (ver_expected ^ ver_actual)) ? false : true; if (!ver_match) goto err_exit; - ver_match = ((dw_minor_mask & ver_expected) > (dw_minor_mask & ver_actual)) ? - false : true; + ver_match = (dw_minor_mask & ver_expected) <= (dw_minor_mask & ver_actual); err_exit: return ver_match; -- 2.34.1