From: Chi Zhiling The return value of do_mpage_readpage() is arg->bio, which is already set in the arg structure. Returning it again is redundant. This patch changes the return type to int and always returns 0 since the caller does not care about the return value. Signed-off-by: Chi Zhiling --- fs/mpage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/mpage.c b/fs/mpage.c index a81a71de8f59..718c2c448947 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -148,7 +148,7 @@ struct mpage_readpage_args { * represent the validity of its disk mapping and to decide when to do the next * get_block() call. */ -static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) +static int do_mpage_readpage(struct mpage_readpage_args *args) { struct folio *folio = args->folio; struct inode *inode = folio->mapping->host; @@ -297,7 +297,7 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) else args->last_block_in_bio = first_block + blocks_per_folio - 1; out: - return args->bio; + return 0; confused: if (args->bio) @@ -360,7 +360,7 @@ void mpage_readahead(struct readahead_control *rac, get_block_t get_block) prefetchw(&folio->flags); args.folio = folio; args.nr_pages = readahead_count(rac); - args.bio = do_mpage_readpage(&args); + do_mpage_readpage(&args); if (!folio_test_locked(folio) && !folio_test_uptodate(folio)) break; @@ -381,7 +381,7 @@ int mpage_read_folio(struct folio *folio, get_block_t get_block) .get_block = get_block, }; - args.bio = do_mpage_readpage(&args); + do_mpage_readpage(&args); if (args.bio) mpage_bio_submit_read(args.bio); return 0; -- 2.43.0