em28xx_v4l2_close() unconditionally evaluates interface_to_usbdev(dev->intf) at function entry, before acquiring dev->lock and checking dev->disconnected. If the USB device was disconnected while /dev/video0 was still open, struct usb_interface (dev->intf) has already been freed by usb_disable_device() -> device_release(), so closing the file handle triggers a KASAN slab-use-after-free: BUG: KASAN: slab-use-after-free in em28xx_v4l2_close+0x37c/0x3a0 Read of size 8 at addr ffff888007245890 by task test_em28xx_uaf/71 ... Freed by task 10: kfree+0x162/0x410 device_release+0xca/0x250 kobject_put+0x152/0x2f0 usb_disable_device+0x324/0x570 usb_disconnect+0x271/0x950 Move the interface_to_usbdev(dev->intf) lookup after the dev->disconnected check under dev->lock, right before its only user usb_set_interface(). Tested locally in QEMU (x86_64, KASAN+UBSAN) using dummy_hcd and raw-gadget emulating an EM2820 device across open->disconnect->close, repeated disconnect, dual-fd open->disconnect->close, and normal open->close->disconnect scenarios (8/8 passed, 0 KASAN reports). Fixes: c6d48134cb26 ("[media] em28xx: don't store usb_device at struct em28xx") Cc: stable@vger.kernel.org Signed-off-by: Arbab Haider --- Changes in v2: - Add Fixes: tag as requested by Media CI. drivers/media/usb/em28xx/em28xx-video.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index 84424284d..854fcc897 100644 --- a/drivers/media/usb/em28xx/em28xx-video.c +++ b/drivers/media/usb/em28xx/em28xx-video.c @@ -2503,7 +2503,6 @@ static int em28xx_v4l2_close(struct file *filp) struct video_device *vdev = video_devdata(filp); struct em28xx *dev = video_drvdata(filp); struct em28xx_v4l2 *v4l2 = dev->v4l2; - struct usb_device *udev = interface_to_usbdev(dev->intf); int err; bool last_user; @@ -2512,6 +2511,8 @@ static int em28xx_v4l2_close(struct file *filp) _vb2_fop_release(filp, vdev->queue->lock); if (last_user) { + struct usb_device *udev; + /* No sense to try to write to the device */ if (dev->disconnected) goto exit; @@ -2525,6 +2526,7 @@ static int em28xx_v4l2_close(struct file *filp) /* set alternate 0 */ dev->alt = 0; em28xx_videodbg("setting alternate 0\n"); + udev = interface_to_usbdev(dev->intf); err = usb_set_interface(udev, 0, 0); if (err < 0) { dev_err(&dev->intf->dev, -- 2.53.0