The peer flow add path hands the duplicated flow over to the origin flow before it looks up the peer entry for the peer vhca_id. When that entry is missing, the function returns -ENODEV, and the caller then deletes the duplicated flow with list_del() on its peer node, a list head that was never initialised and never linked. list_del() on such a node writes through the NULL page. Look the peer entry up before the duplicated flow is created and handed over, so that a missing entry is reported without leaving a duplicated flow behind. The entry cannot change in between: the peer loop in mlx5e_add_fdb_flow() holds the devcom component's read lock, and peer_flows entries are only stored and erased by the pair and unpair events, under its write lock. Found by code review and not reproduced; compile-tested only. AI assistance was used. Fixes: 9d608a40c2d4 ("net/mlx5e: TC, track peer flows in a vhca_id xarray") Signed-off-by: Zhao Li --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 708b7987ea4c..d41969117d30 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -4630,6 +4630,10 @@ static int mlx5e_tc_add_fdb_peer_flow(struct flow_cls_offload *f, else in_mdev = priv->mdev; + dup_peer_flows = xa_load(&esw->offloads.peer_flows, peer_vhca_id); + if (!dup_peer_flows) + return -ENODEV; + flow_flags |= BIT(MLX5E_TC_FLOW_FLAG_PEER); parse_attr = flow->attr->parse_attr; peer_flow = __mlx5e_add_fdb_flow(peer_priv, f, flow_flags, @@ -4643,9 +4647,6 @@ static int mlx5e_tc_add_fdb_peer_flow(struct flow_cls_offload *f, peer_flow->peer_orig = flow; list_add_tail(&peer_flow->peer_flows, &flow->peer_flows); flow_flag_set(flow, DUP); - dup_peer_flows = xa_load(&esw->offloads.peer_flows, peer_vhca_id); - if (!dup_peer_flows) - return -ENODEV; mutex_lock(&esw->offloads.peer_mutex); list_add_tail(&peer_flow->peer, dup_peer_flows); mutex_unlock(&esw->offloads.peer_mutex); base-commit: 6b4b543fa18757297ac756a6fe6e64f506b7844a -- 2.56.1