From: Pu Lehui If a subprogram fails to JIT in jit_subprogs(), previously JITed subprograms are freed. However, the generic bpf_jit_free() fails to free their leftover jit_data, causing a memory leak. Implement a custom bpf_jit_free() to free this data. Fixes: 5f5a64111639 ("bpf: sparc64: Add JIT support for multi-function programs.") Reported-by: Sashiko Signed-off-by: Pu Lehui --- arch/sparc/net/bpf_jit_comp_64.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c index 2fa0e9375127..b5892cdce711 100644 --- a/arch/sparc/net/bpf_jit_comp_64.c +++ b/arch/sparc/net/bpf_jit_comp_64.c @@ -1611,3 +1611,22 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_verifier_env *env, struct bpf_pr } goto out_off; } + +void bpf_jit_free(struct bpf_prog *fp) +{ + if (fp->jited) { + struct sparc64_jit_data *jit_data = fp->aux->jit_data; + struct bpf_binary_header *hdr = bpf_jit_binary_hdr(fp); + + /* Cleanup for earlier subprogs if jit_subprogs() aborts */ + if (jit_data) { + kfree(jit_data->ctx.offset); + kfree(jit_data); + } + + bpf_jit_binary_free(hdr); + WARN_ON_ONCE(!bpf_prog_kallsyms_verify_off(fp)); + } + + bpf_prog_unlock_free(fp); +} -- 2.34.1