After registering a VLAN device and setting its feature flags, we need to synchronize the VLAN features with the lower device. For example, the VLAN device does not have the NETIF_F_LRO flag, it should be synchronized with the lower device based on the NETIF_F_UPPER_DISABLES definition. As the dev->vlan_features has changed, we need to call netdev_change_features(). The caller must run after netdev_upper_dev_link() links the lower devices, so this patch adds the netdev_change_features() call in register_vlan_dev(). Signed-off-by: Hangbin Liu --- I’m not sure what the proper Fixes tag should be, so I’ve left it blank for now. If anyone has a clue, please let me know. --- net/8021q/vlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index fda3a80e9340..4857fb0ee11d 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -193,6 +193,8 @@ int register_vlan_dev(struct net_device *dev, struct netlink_ext_ack *extack) vlan_group_set_device(grp, vlan->vlan_proto, vlan_id, dev); grp->nr_vlan_devs++; + netdev_change_features(dev); + return 0; out_unregister_netdev: -- 2.50.1