In mt7925_set_key(), when configuring a key on an MLD interface with key->link_id == -1 and msta->valid_links == 0 (for example during link teardown or key removal), for_each_set_bit() executes zero iterations and mt7925_set_key() returns an uninitialized stack variable err. Initialize err to 0, matching mt7996_set_key(). Found via Clang -Wconditional-uninitialized on an x86_64 allyesconfig build. Verified by building drivers/net/wireless/mediatek/mt76/mt7925/ with LLVM=1 W=1 (-Werror) and -Wconditional-uninitialized; not runtime-tested on MT7925 hardware. Fixes: 3e758e9f777c ("wifi: mt76: mt7925: add link handling in mt7925_set_key") Signed-off-by: Ian Rogers --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net/wireless/mediatek/mt76/mt7925/main.c index 8d591f265260..e39e4674e26d 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -735,7 +735,7 @@ static int mt7925_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, struct mt792x_sta *msta = sta ? (struct mt792x_sta *)sta->drv_priv : &mvif->sta; struct mt792x_link_sta *mlink; - int err; + int err = 0; /* The hardware does not support per-STA RX GTK, fallback * to software mode for these. -- 2.56.1.708.g77570a6a1d-goog