From: Amir Dahan Restore qcom,num-strings to the default of 4. Downstream had qcom,led-strings-list = [00 01 02] set, so for upstream we assumed qcom,num-strings was 3. [1] However downstream also overrides qcom,num-strings to 4 in the driver [2]. Therefore, the correct value is 4, and that value is already the default, so we don't need to set it in sdm845-lg-common at all. [1]: https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-judy/sdm845-judyln_lao_com/sdm845-judyln_lao_com-panel.dtsi#L29 [2]: https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/drivers/leds/leds-qpnp-wled.c#L691 Fixes: c6c66aa3ef33 ("arm64: dts: qcom: sdm845-lg-judyln: Add display panel") Signed-off-by: Amir Dahan Signed-off-by: Paul Sajna --- arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi index 84f0e1f0bcd3..e1ecd43cba0f 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi @@ -538,7 +538,6 @@ &pmi8998_wled { qcom,current-limit-microamp = <20000>; qcom,ovp-millivolt = <29600>; qcom,switching-freq = <800>; - qcom,num-strings = <3>; qcom,cabc; status = "okay"; }; --- base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b change-id: 20261108-fix-judyln-backlight-be385341ce7a Best regards, -- Paul Sajna