Buffered writeback can complete data I/O successfully but fail to convert unwritten extents, for example when allocating an extent path returns ENOMEM. ext4_end_io_end() logs the failure and returns an error, but the conversion worker discards that return value. As a result, fsync() can report success while the extents remain unwritten and direct reads return zeros instead of the data written. Record the error in the inode mapping before ext4_release_io_end() ends folio writeback. This lets fsync() observe the error after waiting for writeback. Fixes: b82e384c7bb9 ("ext4: optimize locking for end_io extent conversion") Cc: stable@vger.kernel.org Signed-off-by: Julian Sun --- fs/ext4/page-io.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 734d856a6d47..d409821fefa2 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -193,6 +193,10 @@ static int ext4_end_io_end(ext4_io_end_t *io_end) } else { ret = ext4_convert_unwritten_io_end_vec(handle, io_end); } + + if (ret < 0) + mapping_set_error(inode->i_mapping, ret); + if (ret < 0 && !ext4_emergency_state(sb) && io_end->flag & EXT4_IO_END_UNWRITTEN) { ext4_msg(sb, KERN_EMERG, -- 2.39.5