irq_suspended and irq_rerun share a word with link, autoneg_complete and interrupts. phy_interrupt() sets irq_rerun from the IRQ thread without phydev->lock, while the state machine writes link and autoneg_complete under it and phy_request_interrupt()/ phy_free_interrupt() write interrupts, so one read-modify-write can undo another. A lost irq_rerun leaves the PHY interrupt disabled after resume, as phy_interrupt() has already disabled the line. The next patch sets irq_suspended for PHYs whose MAC driver manages PHY PM; with stmmac that happens before the MAC stops the PHY, which widens the window. Make both flags bools. Fixes: 1758bde2e4aa ("net: phy: Don't trigger state machine while in suspend") Signed-off-by: Igor Velkov --- include/linux/phy.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/phy.h b/include/linux/phy.h index 21afc2082b17..ec2c4d9a15d3 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -726,8 +726,9 @@ struct phy_device { /* Interrupts are enabled */ unsigned interrupts:1; - unsigned irq_suspended:1; - unsigned irq_rerun:1; + /* irq_rerun is set by the IRQ thread: not bitfields */ + bool irq_suspended; + bool irq_rerun; unsigned default_timestamp:1; -- 2.43.0