prueth_probe() takes references on the eth0_node/eth1_node device nodes with of_node_get() and stores them in prueth->eth_node[]. If either of the "ti,mii-g-rt" or "ti,mii-rt" syscon regmap lookups fails, probe() returns -ENODEV without dropping those references, leaking the device nodes. Jump to the existing put_cores label so the error path releases the eth0_node/eth1_node references like all the other failure paths in the function do. Fixes: e654b85a693e ("net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms") Signed-off-by: Xiangwu Lai --- Changes in v2: - Collect the two independent fixes into one series (suggested by Simon Horman). - No code change since v1. Link: https://lore.kernel.org/netdev/20261030085851.2019-1-laixiangwu@cmss.chinamobile.com/ drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c index b8115ca47..ef1dc32ff 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c @@ -963,13 +963,15 @@ static int prueth_probe(struct platform_device *pdev) prueth->miig_rt = syscon_regmap_lookup_by_phandle(np, "ti,mii-g-rt"); if (IS_ERR(prueth->miig_rt)) { dev_err(dev, "couldn't get ti,mii-g-rt syscon regmap\n"); - return -ENODEV; + ret = -ENODEV; + goto put_cores; } prueth->mii_rt = syscon_regmap_lookup_by_phandle(np, "ti,mii-rt"); if (IS_ERR(prueth->mii_rt)) { dev_err(dev, "couldn't get ti,mii-rt syscon regmap\n"); - return -ENODEV; + ret = -ENODEV; + goto put_cores; } if (eth0_node) { -- 2.50.1.windows.1