ipc_imem_cleanup() cancels the other imem hrtimers but not adb_timer, which the UL aggregation path arms for 500 us. If it is still pending when the device is removed, its callback queues a task that finishes the ADB on the freed MUX, and the hrtimer itself is freed with the imem. Cancel it along with the other timers. Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support") Cc: stable@vger.kernel.org Signed-off-by: David Westen --- Notes: Build-tested, and run as part of this series on an XMM7360 that uses MUX aggregation, so the timer is armed there. I haven't reproduced the race itself. It comes before the S3 fix in the next patch, which makes this teardown run on every S3. drivers/net/wwan/iosm/iosm_ipc_imem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem.c b/drivers/net/wwan/iosm/iosm_ipc_imem.c index 4405c8531888..20f8da53a3ea 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_imem.c +++ b/drivers/net/wwan/iosm/iosm_ipc_imem.c @@ -1239,6 +1239,7 @@ void ipc_imem_cleanup(struct iosm_imem *ipc_imem) hrtimer_cancel(&ipc_imem->tdupdate_timer); hrtimer_cancel(&ipc_imem->fast_update_timer); hrtimer_cancel(&ipc_imem->startup_timer); + hrtimer_cancel(&ipc_imem->adb_timer); /* cancel the workqueue */ cancel_work_sync(&ipc_imem->run_state_worker); base-commit: e203d8a4751d48aa00eda31e3b320ba8e0d47dbf -- 2.56.0